-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows and bindings support #5
Conversation
Add initial support for making windows delay-link library which hopefully we will be able to link against. qemu-plugins has win_link_hook which does the runtime link-up to the host qemu.exe. the tiny example compiles and runs for me now. No way to access g_free on windows, so we instead leak memory at the moment.
I had a couple of ideas about the g_free problem, but haven't had a chance to try them yet.
|
Good enough for me, IMO better to make it work now than stress too much about it breaking in the future! Thanks for testing this out! |
I know combining "fix CI" and "add a feature" in one PR is bad practice, but luckily this repo has 5 stars so I think I can get away with it for now. I'll merge this once I can get CI to work, I just checked and there's enough space so something else weird is going on. The built image is 30.2GB, well under the available space. |
Getting there, Linux CI is working and what I'm trying to do for Windows CI is working locally :) |
…Hing and just stop process
Alrighty, it's not much but we are now testing Linux & Windows plugins in CI so that's cool! Thanks for doing the heavy lifting @tocklime! |
Adds @tocklime's windows support and a few fixes and cleanups around it.